Skip to content

Make possible to pass custom headers in the SDKs#656

Merged
mishushakov merged 5 commits intomainfrom
make-possible-to-pass-custom-headers-in-the-sdks-e2b-1933
Apr 3, 2025
Merged

Make possible to pass custom headers in the SDKs#656
mishushakov merged 5 commits intomainfrom
make-possible-to-pass-custom-headers-in-the-sdks-e2b-1933

Conversation

@mishushakov
Copy link
Copy Markdown
Member

@mishushakov mishushakov commented Apr 2, 2025

This feature allows passing custom headers in the Python and JS SDK. One use-case for it currently is passing custom authorization (Supabase) headers with the request.

@mishushakov mishushakov added sdk Improvements or additions to SDKs Improvement Improvement for current functionality labels Apr 2, 2025
@mishushakov mishushakov self-assigned this Apr 2, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: ee58f5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@e2b/python-sdk Patch
e2b Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dobrac
Copy link
Copy Markdown
Contributor

dobrac commented Apr 2, 2025

Just to clarify, why did you choose to be able to override existing default headers?

@mishushakov
Copy link
Copy Markdown
Member Author

for my personal DX, hehe, it should only override the specific ones

@jakubno
Copy link
Copy Markdown
Member

jakubno commented Apr 2, 2025

What's the use case? How is it related to Supabase Auth implementation? Either we want to support it natively or we don't right?

@mishushakov
Copy link
Copy Markdown
Member Author

This is an escape hatch how one can pass custom headers (in my case X-Supabase-Token and X-Supabase-Team)

Copy link
Copy Markdown
Member

This is for the API client, right? Not for the request to sandboxes?

@mishushakov
Copy link
Copy Markdown
Member Author

@ValentaTomas correct, not touching envd or jupyter

Copy link
Copy Markdown
Member

@ValentaTomas ValentaTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mishushakov mishushakov merged commit 1bdf809 into main Apr 3, 2025
5 checks passed
@mishushakov mishushakov deleted the make-possible-to-pass-custom-headers-in-the-sdks-e2b-1933 branch April 3, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Improvement for current functionality sdk Improvements or additions to SDKs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants